make SplunkPostDocLoadResourceInstrumentation aware of upstream context (#357) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm looks like i still didn't get the signing right, will take another look Monday |
sfishel-splunk
force-pushed
the
sfishel/context-aware-post-load-resource-instrumentation
branch
from
2aa6b30
to
1d8fe35
Compare
t2t2
approved these changes
Jul 8, 2022
mhennoch
approved these changes
Jul 8, 2022
sfishel-splunk
force-pushed
the
sfishel/context-aware-post-load-resource-instrumentation
branch
3 times, most recently
from
bfaeadd
to
3ffb624
Compare
…xt (signalfx#357) * add a mutation observer for the document head to capture added <script> and <img> tags, maintaining a mapping of the source URLs of those elements to the span context when they were inserted * use that mapping to look up parent context when creating spans for those resource fetches * add hooks to SplunkContextManager to ensure that mutation observer records can be processed in the same context as the logic that initiates the resource load
sfishel-splunk
force-pushed
the
sfishel/context-aware-post-load-resource-instrumentation
branch
from
3ffb624
to
4307c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintaining a mapping of the source URLs of those elements to the span context when they were inserted
context as the logic that initiates the resource load
Description
Problem: when a resourceFetch span is created by the SplunkPostDocLoadResourceInstrumentation, context is not propagated from the code that initiated the resource load.
Solution: use a mutation observer to detect when new elements are added to the document head and record the tracing context at that time, to be used later when resourceFetch spans are created.
Fixes #357
Type of change
How has this been tested?
Checklist: