Output escaping is broken

[schorsch3000]

At least variable values are not propperly escaped.
e.g. running the demo.sh like this:

export foo="this is broken" ; ./demo.sh download -t '$foo' bar

should result in

cmd:                      download
flag:   --force           
option: --tries           $foo
arg:    source            bar
arg:    target            

but results in

cmd:                      download
flag:   --force           
option: --tries           this is broken
arg:    source            bar
arg:    target 

this is since calling argc -e demo.sh download -t '$foo' bar results in

argc_tries="$foo"
argc_source="bar"
download
``` riight there is an unescaped `$foo`

[sigoden]

I didn't notice that the quotes should be kept

I'll deal with this later

[schorsch3000]

I'm really not fluent in rust, but in bash and it seems you should use someting like https://docs.rs/shellwords/latest/shellwords/fn.escape.html to output variable contents and connands

[sigoden]

The problem occurs a little further ahead。The value '$foo' lose quotes before it assigned to a variable during clap parsing parameters.

The escape is not a problem:

./demo.sh download file1 '"abc\""efg"\" "'

cmd:                      download
flag:   --force           
option: --tries           
arg:    source            file1
arg:    target            "abc\""efg"\" "

[schorsch3000]

Imo that is exactly the problem.
im my example the actual value of the parameter is $foo '$foo' id the syntax in shell to gove $foo as value

[sigmonsays]

Proper escaping needs to be added for all escapes.. It's not just dollar sign, that was only a trivial example. Also, its not just variables that are excuted, all shell commands are because of the dangerous use of eval. Imagine pwd being changed to rm -rf below...

Take these examples

demo.sh download -t '$(pwd)' asdf

demo.sh download -t '`pwd`' asdf

[schorsch3000]

I'm afraid it's far from fixed right now.
at least "'" or "\\1" as parameters breaks things.

my simple testsetup:

#!/bin/bash
# @describe A demo cli
# @arg value! a test value
eval "$(argc -e $0 "$@")"
if [[ "$1" == "$argc_value" ]]; then
  echo "Okay"
else
  echo "ERROR $1 results in $argc_value"
fi

Shell quotiong really isn'T simple. pleas reconsider using a proven library for that job

[sigoden]

Okay, I've a new build. Please test it!

[schorsch3000]

Testing 0.3.1 i'Ve found the following problematic argument values:

"a "
"²"
"ö"

or any other mulitbyte character