Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle IP changes gracefully #194

Closed
AgeManning opened this issue Jun 14, 2023 · 1 comment
Closed

Handle IP changes gracefully #194

AgeManning opened this issue Jun 14, 2023 · 1 comment
Assignees
@ackintosh

Comments

@AgeManning
Copy link
Member

A connected node, when its external ip changes will have an ENR with a set ip which does not match its outbound socket.

A discv5 node will not create a session with these because the ENR is currently non-contactable. We should allow for a mechanism (i.e PING) whereby these nodes can get PONG responses to find out their IP has changed an update their ENR's accordingly. This is being worked on in #184
@ackintosh ackintosh mentioned this issue Jun 16, 2023
Merged
@divagant-martian
Copy link
Collaborator

closed by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ackintosh ackintosh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ackintosh @AgeManning @divagant-martian