[Merged by Bors] - Wallet creation: Make mnemonic length configurable, default to 24 words. #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
`lighthouse account_manager wallet create` now generates a 24-word mnemonic. The user can override this by passing `--mnemonic-length 12` (or another legal bip39 length).
goffrie
force-pushed
the
mnemonic-length
branch
from
624ceaa
to
771adc1
Compare
michaelsproul
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Hey @goffrie, thanks very much for the PR, this looks great!
If you could please sign the contributor license agreement by following the link that the bot posted above, we can get this merged!
|
Nominating for inclusion in v0.3.0, as it's a major breaking change. |
|
Signed :) |
paulhauner
approved these changes
Oct 2, 2020
bors bot
pushed a commit
that referenced
this pull request
Oct 2, 2020
…ds. (#1697) ## Issue Addressed Fixes #1665. ## Proposed Changes `lighthouse account_manager wallet create` now generates a 24-word mnemonic. The user can override this by passing `--mnemonic-length 12` (or another legal bip39 length). ## Additional Info CLI `--help`: ``` --mnemonic-length <MNEMONIC_LENGTH> The number of words to use for the mnemonic phrase. [default: 24] ``` In case of an invalid argument: ``` % lighthouse account_manager wallet create --mnemonic-length 25 error: Invalid value for '--mnemonic-length <MNEMONIC_LENGTH>': Mnemonic length must be one of 12, 15, 18, 21, 24 ```
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
paulhauner
pushed a commit
that referenced
this pull request
Oct 3, 2020
…ds. (#1697) ## Issue Addressed Fixes #1665. ## Proposed Changes `lighthouse account_manager wallet create` now generates a 24-word mnemonic. The user can override this by passing `--mnemonic-length 12` (or another legal bip39 length). ## Additional Info CLI `--help`: ``` --mnemonic-length <MNEMONIC_LENGTH> The number of words to use for the mnemonic phrase. [default: 24] ``` In case of an invalid argument: ``` % lighthouse account_manager wallet create --mnemonic-length 25 error: Invalid value for '--mnemonic-length <MNEMONIC_LENGTH>': Mnemonic length must be one of 12, 15, 18, 21, 24 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes #1665.
Proposed Changes
lighthouse account_manager wallet createnow generates a 24-wordmnemonic. The user can override this by passing
--mnemonic-length 12(or another legal bip39 length).
Additional Info
CLI
--help:In case of an invalid argument: