Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate 24-word mnemonics by default #1665

Closed
michaelsproul opened this issue Sep 25, 2020 · 0 comments
Closed

Generate 24-word mnemonics by default #1665

michaelsproul opened this issue Sep 25, 2020 · 0 comments

Comments

@michaelsproul
Copy link
Member

Description

We presently use 12-word mnemonics in lighthouse account wallet create. For consistency with other source (eth2 deposit CLI and other clients), and for increased entropy, I think it makes sense to use 24-word mnemonics by default.
@michaelsproul michaelsproul mentioned this issue Sep 25, 2020
Closed
@goffrie goffrie mentioned this issue Oct 1, 2020
Closed
@michaelsproul michaelsproul mentioned this issue Oct 1, 2020
Closed
@bors bors bot closed this as completed in 2cc2010 Oct 2, 2020
paulhauner pushed a commit that referenced this issue Oct 3, 2020
@goffrie @paulhauner
Wallet creation: Make mnemonic length configurable, default to 24 wor…
8fde9a4 
…ds. (#1697)

## Issue Addressed

Fixes #1665.

## Proposed Changes

`lighthouse account_manager wallet create` now generates a 24-word
mnemonic. The user can override this by passing `--mnemonic-length 12`
(or another legal bip39 length).

## Additional Info

CLI `--help`:
```
        --mnemonic-length <MNEMONIC_LENGTH>       The number of words to use for the mnemonic phrase. [default: 24]
```

In case of an invalid argument:
```
% lighthouse account_manager wallet create --mnemonic-length 25
error: Invalid value for '--mnemonic-length <MNEMONIC_LENGTH>': Mnemonic length must be one of 12, 15, 18, 21, 24
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@michaelsproul