Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update docs whenever unstable changes #1969

Closed
wants to merge 1 commit into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Presently master is stable (and will be sunsetted) which means our docs only update after a release. This PR sets the docs to build on the unstable branch, which is equivalent to what what we've always had.

Additional Info

This does raise the question of whether or not docs should target stable or unstable, but I'd prefer to maintain current functionality and merge #1966 for now. I think having two versions might be handy, one for stable and one for unstable; I don't imagine this very difficult to achieve.

@paulhauner paulhauner added ready-for-review The code is ready for review A0 labels Nov 25, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

LGTM

@ghost
Copy link

ghost commented Nov 25, 2020

bors r+

bors bot pushed a commit that referenced this pull request Nov 25, 2020
## Issue Addressed

NA

## Proposed Changes

Presently `master` is stable (and will be sunsetted) which means our docs only update after a release. This PR sets the docs to build on the `unstable` branch, which is equivalent to what what we've always had. 

## Additional Info

This does raise the question of whether or not docs should target `stable` or `unstable`, but I'd prefer to maintain current functionality and merge #1966 for now. I think having two versions might be handy, one for stable and one for unstable; I don't imagine this very difficult to achieve.
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 25, 2020
@bors bors bot changed the title Update docs whenever unstable changes [Merged by Bors] - Update docs whenever unstable changes Nov 25, 2020
@bors bors bot closed this Nov 25, 2020
@michaelsproul michaelsproul deleted the docs-unstable branch November 27, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant