[Merged by Bors] - Add remotekey API support #3162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthebst
commented
Apr 18, 2022
8 tasks
michaelsproul
requested changes
May 6, 2022
michaelsproul
added
waiting-on-author
michaelsproul
approved these changes
May 8, 2022
There was a problem hiding this comment.
Latest changes look great! There are just two things we need to do before merging:
- Remove the
// DO NOT MERGEsection - Satisfy Clippy: https://github.com/sigp/lighthouse/runs/6343319556?check_suite_focus=true
michaelsproul
added
ready-for-merge
|
LFG! 🚀 bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
## Issue Addressed #3068 ## Proposed Changes Adds support for remote key API. ## Additional Info Needed to add `is_local_keystore` argument to `delete_definition_and_keystore` to know if we want to delete local or remote key. Previously this wasn't necessary because remotekeys(web3signers) could be deleted.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#3068
Proposed Changes
Adds support for remote key API.
Additional Info
Needed to add
is_local_keystoreargument todelete_definition_and_keystoreto know if we want to delete local or remote key. Previously this wasn't necessary because remotekeys(web3signers) could be deleted.