[Merged by Bors] - Complete match for has_context_bytes
#3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89290c4.
pawanjay176
reviewed
Feb 15, 2023
| _ => return false, | ||
| match self.message_name { | ||
| Protocol::BlocksByRange | Protocol::BlocksByRoot => { | ||
| !matches!(self.version, Version::V1) |
There was a problem hiding this comment.
Actually, it might be better if we explicitly match Version::V2 instead of excluding V1. If there's a V3 in the future, can't say for sure if that would have a similar mechanism for context bytes.
There was a problem hiding this comment.
Added this and similar for the light client endpoint, but the fact that we're now going to handle a light client protocol + version combination that doesn't exist let me to thinking about this more broadly: #3980
Closed
AgeManning
approved these changes
Feb 20, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
## Issue Addressed - Add a complete match for `Protocol` here. - The incomplete match was causing us not to append context bytes to the light client protocols - This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught Co-authored-by: realbigsean <seananderson33@gmail.com>
michaelsproul
added
ready-for-merge
|
Build failed: |
|
I haven't re-bors'd this because we're finalizing the v3.5.0 release today (and this isn't tagged for it) and I'm not sure if this requires some testing or not. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
## Issue Addressed - Add a complete match for `Protocol` here. - The incomplete match was causing us not to append context bytes to the light client protocols - This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
## Issue Addressed - Add a complete match for `Protocol` here. - The incomplete match was causing us not to append context bytes to the light client protocols - This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught Co-authored-by: realbigsean <seananderson33@gmail.com>
|
I think this needs updating for Capella (and BlobsByRange). |
|
bors r- |
|
Canceled. |
michaelsproul
added
waiting-on-author
paulhauner
added
v4.0.0
…ght-client-protocol-match
|
I think no updates are required since #4019 was merged, so I just merged with unstable and looks like CI passed |
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
## Issue Addressed - Add a complete match for `Protocol` here. - The incomplete match was causing us not to append context bytes to the light client protocols - This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught Co-authored-by: realbigsean <seananderson33@gmail.com>
bors
bot
changed the title
has_context_byteshas_context_bytes
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed - Add a complete match for `Protocol` here. - The incomplete match was causing us not to append context bytes to the light client protocols - This is the relevant part of the spec and it looks like context bytes are defined https://github.com/ethereum/consensus-specs/blob/dev/specs/altair/light-client/p2p-interface.md#getlightclientbootstrap Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught Co-authored-by: realbigsean <seananderson33@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Protocolhere.Disclaimer: I have no idea if people are using it but it shouldn't have been working so not sure why it wasn't caught