Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Complete match for has_context_bytes #3972

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Complete match for has_context_bytes #3972

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0944448
has context bytes complete match
realbigsean Feb 13, 2023
89290c4
empty commit
realbigsean Feb 13, 2023
d6d6588
Revert "empty commit"
realbigsean Feb 13, 2023
5dc5be4
complete match version
realbigsean Feb 15, 2023
be847de
Merge branch 'unstable' of https://github.com/sigp/lighthouse into li…
realbigsean Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 9 additions & 6 deletions beacon_node/lighthouse_network/src/rpc/protocol.rs
View file
Open in desktop
Expand Up @@ -344,13 +344,16 @@ impl ProtocolId {
/// Returns `true` if the given `ProtocolId` should expect `context_bytes` in the
/// beginning of the stream, else returns `false`.
pub fn has_context_bytes(&self) -> bool {
if self.version == Version::V2 {
match self.message_name {
Protocol::BlocksByRange | Protocol::BlocksByRoot => return true,
_ => return false,
}
match self.message_name {
Protocol::BlocksByRange | Protocol::BlocksByRoot => match self.version {
Version::V2 => true,
Version::V1 => false,
},
Protocol::LightClientBootstrap => match self.version {
Version::V2 | Version::V1 => true,
},
Protocol::Goodbye | Protocol::Ping | Protocol::Status | Protocol::MetaData => false,
}
false
}
}

Expand Down