fix: update outdated links to external resources #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chong-he
reviewed
Dec 19, 2023
| @@ -31,6 +31,6 @@ Alternatively, you can find the `lighthouse` binary at: | |||
|
|
|||
| The [formula][] is kept up-to-date by the Homebrew community and a bot that lists for new releases. | |||
|
|
|||
| The package source can be found in the [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/lighthouse.rb) repo. | |||
| The package source can be found in the [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/l/lighthouse.rb) repo. | |||
There was a problem hiding this comment.
This is fixed in #4822 in the unstable branch but I see no conflict so it should be good
There was a problem hiding this comment.
Yep, my mistake I should start from the unstable branch instead of stable ...
michaelsproul
approved these changes
Dec 20, 2023
|
@chong-he is there anything from my side that needs to be done? |
No, this is ready to be merged once it passes all checks, thanks! |
dapplion
approved these changes
Jan 29, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 47f05ac |
This was referenced Jan 29, 2024
merge queue: embarking unstable (c7e5dd1) and [#5103 + #5135 + #5120 + #5065 + #5018] together
#5139
Closed
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* fix: update outdated links to external resources * Update style guide link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I didn't create a specific issue, because changes are trivial, and only documentation is updated.
Proposed Changes
I've found some outdated links to external resources, this PR fixes them.
Additional Info
No additional info.