Move from igd to igd-next #5068
Merged
+22
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: useless conversion to the same type: `std::net::IpAddr`
AgeManning
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
This looks fine to me. Will wait for @jxs to have a look also
jxs
approved these changes
Jan 31, 2024
|
Thanks Akihito! |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b9c519d |
5 tasks
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* Move from igd to igd-next * Fix clippy error warning: useless conversion to the same type: `std::net::IpAddr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5020
Proposed Changes
Move from igd to igd-next v0.14.3, which contains fix for the panic issue.
Additional Info