Remove erroneous bash evaluation from scripts/cli.sh
#5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
bug
michaelsproul
approved these changes
Jan 24, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0b6c898 |
michaelsproul
added
ready-for-merge
5 tasks
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5041 introduced some hints for how to solve CI errors relating to the CLI help text files added in #4571
This had an unfortunate side effect. Since
make cliandmake cli-localwere encased in back-ticks and echoed to the user, it caused Bash to evaluate them in the terminal.We saw a case of this occurring on CI here.
The log line:
indicates that the CI job attempted to spin up a nested docker container which failed.
There were also effects seen locally. Running
make cli-localwould actually end up triggeringmake cliin the event that changes were required so you would end up seeing Docker logs. Luckily, we did not echo the offending line in the event that no changes were made, which prevented a infinite recursion situation.Proposed Changes
Replace the back-ticks with single quotes which do not get evaluated.