Drop gossipsub stale messages when polling ConnectionHandler. #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Feb 4, 2024
to be able to Peek next message without dropping it
jxs
force-pushed
the
drop-gossipsub-stale-messages
branch
from
15ddd5f
to
cb33247
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 256d904 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following scenario:
ConnectionHandleris slow transfering a message, therefore messages accumulate. These messages timeout may elapse and fill the queue, but ConnectionHandler will only discard them when reading the next message to send from the queue.This PR helps ease that situation by reading the next message when
ConnectionHandleris polled and discarding it if its timeout has elapsed.