increment peer per topic count on graft messages #5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
fix-gossipsub-peer-topic-metrics
branch
from
e283192
to
159b504
Compare
AgeManning
approved these changes
Feb 7, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 675a231 |
5 tasks
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* increment peer per topic count on graft messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The
topic_peers_countsmetric currently goes negative on some cases, which realistically is a bug, this patch hopefully addresses that by also incrementing thetopic_peer_countswhen aGRAFTmessage is received and the topic is added toconnected_peerwhich sent it