Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curve25519-dalek patch #5214

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 7, 2024

Issue Addressed

Addresses #5204.

Fix for the breaking change released in 4.1.2.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 7, 2024
@jimmygchen jimmygchen changed the title Remove curve25519-dalek patch Remove curve25519-dalek patch Feb 7, 2024
@jimmygchen jimmygchen added dependencies Pull requests that update a dependency file v5.0.0 Q1 2024 labels Feb 7, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024 and removed ready-for-review The code is ready for review v5.0.0 Q1 2024 labels Feb 8, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 8, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 8, 2024
@realbigsean
Copy link
Member

realbigsean commented Feb 8, 2024

@Mergifyio requeue

Copy link

mergify bot commented Feb 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 8, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4b19eac

mergify bot added a commit that referenced this pull request Feb 8, 2024
@mergify mergify bot merged commit 4b19eac into sigp:unstable Feb 8, 2024
29 checks passed
danielramirezch pushed a commit to danielramirezch/lighthouse that referenced this pull request Feb 14, 2024
* Remove patch dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants