Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate env_log flag in tracing layer #5228

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Deprecate env_log flag in tracing layer #5228

merged 2 commits into from
Feb 19, 2024

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

#5226

Proposed Changes

Deprecate -l flag functionality. Since we are now capturing these logs in separate files, there doesn't seem to be a reason to also have the option to log these to the terminal. Especially considering how noisy these logs can be.

Additional Info

@eserilev eserilev changed the title deprecate terminal logs file in tracing layer deprecate env_logs flag in tracing layer Feb 12, 2024
@eserilev eserilev changed the title deprecate env_logs flag in tracing layer Deprecate env_log flag in tracing layer Feb 12, 2024
@AgeManning AgeManning added the v5.0.0 Q1 2024 label Feb 18, 2024
@AgeManning
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 18, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen jimmygchen added the ready-for-merge This PR is ready to merge. label Feb 19, 2024
mergify bot added a commit that referenced this pull request Feb 19, 2024
@mergify
Merge of #5228
8346fb5
@mergify mergify bot mentioned this pull request Feb 19, 2024
Closed
5 tasks
@paulhauner
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@paulhauner
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

refresh

✅ Pull request refreshed

@paulhauner
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 19, 2024
@mergify
Merge of #5228
08437ce
@mergify mergify bot mentioned this pull request Feb 19, 2024
Closed
5 tasks
@paulhauner
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4d62595

mergify bot added a commit that referenced this pull request Feb 19, 2024
@mergify
Merge of #5228
bf5b818
This was referenced Feb 19, 2024
Closed
Merged
paulhauner added a commit that referenced this pull request Feb 19, 2024
@paulhauner
Deprecate env_log flag in tracing layer (#5228)
cab9d48 
Squashed commit of the following:

commit 50d0f5c
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Mon Feb 12 23:48:15 2024 +0200

    sink writer

commit 6c29a9d
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Mon Feb 12 23:00:49 2024 +0200

    deprecate terminal logs file in tracing layer
@paulhauner paulhauner mentioned this pull request Feb 19, 2024
Merged
mergify bot added a commit that referenced this pull request Feb 19, 2024
@mergify
Merge of #5228
1024822
@mergify mergify bot mentioned this pull request Feb 19, 2024
Closed
5 tasks
@mergify mergify bot merged commit 4d62595 into sigp:unstable Feb 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eserilev @AgeManning @paulhauner @jimmygchen