Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AddrInUse error in cli tests #5266

Merged
merged 1 commit into from Mar 8, 2024
Merged

Fix AddrInUse error in cli tests #5266

merged 1 commit into from Mar 8, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Another attempt to fix our flaky CI tests due to port conflicts.

Example failure:
https://github.com/sigp/lighthouse/actions/runs/7966087945/job/21746780132

Proposed Changes

  • Remove use of constant ports for tests that binds the ports. The DUMMY_ENR_ ports were meant to be used for enr-xxx-port flag only, and should not be bound, i.e. they must not be used for port or discovery-port.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 20, 2024
@michaelsproul michaelsproul mentioned this pull request Feb 20, 2024
Open
michaelsproul
michaelsproul approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I've opened #5267 to track further improvements to unused_port, as these tests will still be a bit racy

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 21, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 25, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 25, 2024
@mergify
Merge of #5266
6a901f3
This was referenced Feb 25, 2024
Closed
Merged
@michaelsproul
Copy link
Member

@Mergifyio dequeue

@mergify Mergify
Copy link

mergify bot commented Feb 26, 2024

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 26, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 26, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 26, 2024
@mergify
Merge of #5266
b70fbcd
This was referenced Feb 26, 2024
Closed
Merged
Merged
Merged
Merged
mergify bot added a commit that referenced this pull request Feb 26, 2024
@mergify
Merge of #5266
3a9578e
@mergify mergify bot mentioned this pull request Feb 26, 2024
Closed
5 tasks
mergify bot added a commit that referenced this pull request Feb 26, 2024
@mergify
Merge of #5266
91616b0
@mergify mergify bot mentioned this pull request Feb 26, 2024
Closed
5 tasks
@AgeManning
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 28, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 28, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

requeue default

✅ This pull request will be re-embarked automatically

The followup queue default command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024 •
edited

queue default

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 8, 2024
@mergify
Merge of #5266
804bf6d
This was referenced Mar 8, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Mar 8, 2024
@mergify
Merge of #5266
e66efe6
@mergify mergify bot mentioned this pull request Mar 8, 2024
Closed
5 tasks
@paulhauner
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

requeue

☑️ This pull request is already queued

@jimmygchen
Copy link
Member Author

@mergify dequeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

dequeue

☑️ The pull request is not queued

@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 8, 2024
@mergify
Merge of #5266
f17410d
@mergify mergify bot mentioned this pull request Mar 8, 2024
Closed
6 tasks
@paulhauner
Copy link
Member

@mergify dequeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

dequeue

✅ The pull request has been removed from the queue default

@paulhauner
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 762dab2

mergify bot added a commit that referenced this pull request Mar 8, 2024
@mergify
Merge of #5266
15fe1ec
@mergify mergify bot mentioned this pull request Mar 8, 2024
Closed
8 tasks
@mergify mergify bot merged commit 762dab2 into sigp:unstable Mar 8, 2024
29 checks passed
@paulhauner paulhauner mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimmygchen @michaelsproul @AgeManning @paulhauner