Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track multiaddr in connection status #5308

Merged
merged 1 commit into from Feb 27, 2024

Conversation

AgeManning
Copy link
Member

It is useful to know which protocol and address we are connected to for each peer.

This PR keeps track of the multiaddr that created a connection for a peer so that it can be read by our http api in /lighthouse/peers.

This now enables users to see which peers are connected via which protocol and addresses.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Feb 26, 2024
@AgeManning AgeManning requested a review from jxs February 26, 2024 06:05
@AgeManning AgeManning added the v5.1.0 Q2 2024 label Feb 26, 2024
@AgeManning
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Feb 27, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d36241b

mergify bot added a commit that referenced this pull request Feb 27, 2024
@mergify mergify bot merged commit d36241b into sigp:unstable Feb 27, 2024
29 checks passed
pawanjay176 pushed a commit to pawanjay176/lighthouse that referenced this pull request Mar 5, 2024
* Record the multiaddr for connected peers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review v5.1.0 Q2 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants