Attempt to publish to at least mesh_n peers #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Mar 6, 2024
AgeManning
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at fc8f1a4 |
8 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have now disabled flood-publish, we only publish to mesh peers. The mesh can be difficult to manage as the management rules follow the gossipsub specification.
Thanks to @pawanjay176 - We've noticed that it can be the case that we have connected peers on topics but these peers are not in our mesh (perhaps due to their own mesh requirements). Currently, we fail to publish the message if there are no peers in our mesh.
This PR adjusts this logic to always attempt to publish to at least
mesh_npeers. If we have peers that are subscribed to a topic, we will now attempt to publish messages to them (provided they have the required score).While I was here, I also separated the error types between insufficient peers and whether the queue is full, to help debugging and avoid any confusion in the future.