Change private key file permissions #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The
account_manager
generates private keys and stores them with unnecessary extensive permissions. Indeed, private keys are readable by any user of the system (i.e.-rw-r--r--
or0644
permission bits).Proposed Changes
-rw-------
(i.e.0600
)Additional Info
The validator client is about to be refactored, but thought I'd submit this now anyway :)