Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change private key file permissions #551

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@zedt3ster
Copy link
Member

zedt3ster commented Sep 30, 2019

Issue Addressed

The account_manager generates private keys and stores them with unnecessary extensive permissions. Indeed, private keys are readable by any user of the system (i.e. -rw-r--r-- or 0644 permission bits).

Proposed Changes

  • Import libc crate for permission bits
  • Change permissions on private key file generation to -rw------- (i.e. 0600)

Additional Info

The validator client is about to be refactored, but thought I'd submit this now anyway :)

zedt3ster added 2 commits Sep 30, 2019
@zedt3ster zedt3ster requested a review from paulhauner Sep 30, 2019
@paulhauner

This comment has been minimized.

Copy link
Member

paulhauner commented Sep 30, 2019

@mzee I think these tests will pass if you merge in master :)

zedt3ster added 2 commits Sep 30, 2019
@paulhauner paulhauner merged commit 6ae62c9 into master Oct 2, 2019
4 checks passed
4 checks passed
ci/gitlab/change-key-perms Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.