Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDBX #6024

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update MDBX #6024

merged 1 commit into from
Jul 3, 2024

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Closes

Proposed Changes

Update the MDBX bindings so that they can be compiled on more modern C compilers. The pinned commit is just one commit in from of the previous pinned release v0.1.4:

https://github.com/sigp/libmdbx-rs/commits/master/

Additional Info

MDBX is still on the path to deprecation, and we may remove it entirely in a future release.

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! slasher labels Jul 1, 2024
@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 1, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member Author

@mergify requeue

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 3, 2024
Copy link

mergify bot commented Jul 3, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jul 3, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jul 3, 2024
@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jul 3, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jul 3, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 42d1284

mergify bot added a commit that referenced this pull request Jul 3, 2024
@mergify mergify bot merged commit 42d1284 into sigp:unstable Jul 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. slasher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants