Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book: fix broken link in merge-migration.md #6370

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

silvekkk
Copy link

@silvekkk silvekkk commented Sep 7, 2024

Hi there, the original link is expired, I found this one may be the correct one.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this, however I don't think the link provided is the right link for configuring Besu, I don't see the instructions there.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. docs Documentation labels Sep 9, 2024
@chong-he
Copy link
Member

chong-he commented Sep 9, 2024

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

@silvekkk
Copy link
Author

silvekkk commented Sep 9, 2024

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Thanks for the tips fixed now!

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

or we could directly delete them?

@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 10, 2024
@chong-he
Copy link
Member

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Thanks for the tips fixed now!

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

or we could directly delete them?

That could be fine, but keeping them may serve as future references just in case (e.g., some users may want to have a read at the R Pi 4 docs, or what happened back then during The Merge).

Keen to hear from others about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants