Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include compiler version in lighthouse --version #6392

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Include compiler version in lighthouse --version #6392

wants to merge 2 commits into from

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Sep 13, 2024 •
edited
Loading

Proposed Changes

In aid of making builds easier to reproduce, include the compiler's version information in lighthouse --version.

Initial testing for reproducible builds shows that Lighthouse can't (yet) be built bit-identically by make build-x86_64 for the same commit hash & compiler version :(

See:

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! v6.0.0 New major release for hierarchical state diffs labels Sep 13, 2024
@michaelsproul
Copy link
Member Author

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review v6.0.0 New major release for hierarchical state diffs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelsproul