-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document 'SIGSTORE_TRUST_REKOR_API_PUBLIC_KEY' #2122
Comments
+1 |
This option should not be exposed at all -- this trusts the public key by querying Rekor, which provides no protection. Users need to use the other options for setting a custom Rekor key outside of TUF Actually, it should be removed. I'm waiting on scaffolding changes to go through (they are staged right now!) |
This PR was actually incorrect: #2040 I'll put out a fix right now and add documentation on the correct way to set a custom non-TUF Rekor key. |
@asraa That PR was the result of this discussion #1997 (comment). Based on @haydentherapper comment, I assumed that was a well-known usage.
Why are we exposing the public key in rekor API if that could lead to security issues ? |
I think there was just a mistake in the env var that the comment had. See this earlier comment: #1997 (comment) |
👍🏻 , I saw it now in #2124 |
Some services do not expose that for this reason. But it is convenient to double check what the public key is AGAINST an out of band delivered one. |
closing, thanks @asraa |
A few users are being tripped up on this subject env not being documented. There should be an entry in docs.sigstore.dev
The text was updated successfully, but these errors were encountered: