Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate/upload sbom for cosign projects #1237

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Summary

feat: generate/upload sbom for cosign projects

Ticket Link

Fixes #959

Release Note

feat: generate/upload sbom for cosign projects

- uses: imjasonh/setup-ko@v0.4
with:
version: tip
- uses: imjasonh/setup-ko@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still only install the latest release by default. If it doesn't that's a bug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should I need to do exactly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: imjasonh/setup-ko@main
- uses: imjasonh/setup-ko@main
with:
version: tip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes 🤦

@dlorenc
Copy link
Member

dlorenc commented Dec 21, 2021

Is the vuln stuff supposed to be in here?

@developer-guy
Copy link
Member Author

Is the vuln stuff supposed to be in here?

it is my bad, it should be okay right now.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Member Author

okay, it seems that it should be ready to merge @dlorenc If I didn't miss anything

@dlorenc dlorenc merged commit 24d43bd into sigstore:main Dec 22, 2021
@github-actions github-actions bot added this to the v1.5.0 milestone Dec 22, 2021
@developer-guy developer-guy deleted the feature/1202 branch December 26, 2021 17:53
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 25, 2022
https://build.opensuse.org/request/show/949015
by user msmeissn + dimstar_suse
- updated to 1.5.0
  ## Highlights
  * enable sbom generation when releasing (sigstore/cosign#1261)
  * feat: log error to stderr (sigstore/cosign#1260)
  * feat: support attach attestation (sigstore/cosign#1253)
  * feat: resolve --cert from URL (sigstore/cosign#1245)
  * feat: generate/upload sbom for cosign projects (sigstore/cosign#1237)
  * feat: vuln attest support (sigstore/cosign#1168)
  * feat: add ambient credential detection with spiffe/spire (sigstore/cosign#1220)
  * feat: generate/upload sbom for cosign projects (sigstore/cosign#1236)
  * feat: implement cosign download attestation (https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generating SBOMs for both cosign and cosigned projects and sign them
3 participants