Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lowercase input image refs, just fail #1586

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

imjasonh
Copy link
Member

Reverts #1409
Fixes #1568

Summary

Lowercasing the input was supposed to help when the user's requested repo name included uppercase letters (e.g., ghcr.io/MyUser/CAPS-REPO), which isn't allowed. This unintentionally also lowercased the tag component, which is allowed to contain uppercase letters, and lowercasing them breaks the user's expectation.

Release Note

Don't lowercase the input image ref, just fail if it includes uppercase characters

Signed-off-by: Jason Hall <jasonhall@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1586 (adb92ce) into main (c341168) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
- Coverage   27.19%   27.15%   -0.04%     
==========================================
  Files         136      136              
  Lines        7712     7712              
==========================================
- Hits         2097     2094       -3     
- Misses       5386     5388       +2     
- Partials      229      230       +1     
Impacted Files Coverage Δ
cmd/cosign/cli/sign/sign.go 1.62% <0.00%> (ø)
pkg/cosign/tuf/client.go 62.34% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c341168...adb92ce. Read the comment docs.

@dlorenc dlorenc merged commit f13ca43 into sigstore:main Mar 10, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 10, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: Jason Hall <jasonhall@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowercasing the imageref when signing breaks non-lowercase image *tags*
3 participants