cosign clean: Don't log failure if the registry responds with 404 #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remote.Delete expects either a 200 or 202, but if the tag doesn't exist in the registry, some registries (seemingly ECR, maybe others) respond with a 404, which just means there was nothing to delete. This change also refactors logging to only log if the deletion was successful, to avoid confusion if we can tell the tag didn't exist before cleaning. Signed-off-by: Jason Hall <jasonhall@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #1687 +/- ##
==========================================
- Coverage 29.29% 29.24% -0.06%
==========================================
Files 140 140
Lines 8370 8375 +5
==========================================
- Hits 2452 2449 -3
- Misses 5652 5659 +7
- Partials 266 267 +1
Continue to review full report at Codecov.
|
Signed-off-by: Jason Hall <jasonhall@redhat.com>
dlorenc
approved these changes
Mar 30, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…gstore#1687) * cosign clean: Don't log failure if the registry responds with 404 remote.Delete expects either a 200 or 202, but if the tag doesn't exist in the registry, some registries (seemingly ECR, maybe others) respond with a 404, which just means there was nothing to delete. This change also refactors logging to only log if the deletion was successful, to avoid confusion if we can tell the tag didn't exist before cleaning. Signed-off-by: Jason Hall <jasonhall@redhat.com> * fix lint error, use errors.As like cosign copy does Signed-off-by: Jason Hall <jasonhall@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote.Deleteexpects either a200or202, but if the tag doesn't existin the registry, some registries (seemingly ECR, maybe others) respond
with a
404, which just means there was nothing to delete.This change also refactors logging to only log if the deletion was
successful, to avoid confusion if we can tell the tag didn't exist
before cleaning.
Signed-off-by: Jason Hall jasonhall@redhat.com
Fixes #1684