Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/google/go-containerregistry/pkg/authn/k8schain module to f1b065c6cb3d #1889

Merged
merged 1 commit into from
May 17, 2022

Conversation

vpnachev
Copy link
Contributor

Summary

Update github.com/google/go-containerregistry/pkg/authn/k8schain module to f1b065c6cb3d

Ticket Link

Fixes #1878

Release Note

Fix a bug, where cosigned was not using the provided image pull secret but the Google Service Account available on the node.

@hectorj2f
Copy link
Contributor

@vpnachev Please, remember to --signoff your commits.

@hectorj2f
Copy link
Contributor

@imjasonh @vpnachev I am wondering if we could point to main instead, or simply wait for a new release of https://github.com/google/go-containerregistry.

@imjasonh
Copy link
Member

imjasonh commented May 17, 2022

@imjasonh @vpnachev I am wondering if we could point to main instead, or simply wait for a new release of https://github.com/google/go-containerregistry.

The good news is, I plan to cut a release of go-containerregistry today. edit: it's cut now.

The bad news is, because k8schain is in its own module, cutting a release of the main module won't cut a release of the k8schain module.

I'd go get -u github.com/google/go-containerregistry/pkg/authn/k8schain@main here so you get the latest possible k8schain.

@vpnachev
Copy link
Contributor Author

Actually, I spend several hours today to get the latest version however, this seems impossible to me right now because k8schain requires k8s.io/* v0.24.0, however the knative.dev/pkg is not compatible with it.

@vpnachev Please, remember to --signoff your commits.

Done.

…le to f1b065c6cb3d

Signed-off-by: Vladimir Nachev <vladimir.nachev@sap.com>
@dlorenc dlorenc merged commit 6ef1a3a into sigstore:main May 17, 2022
@github-actions github-actions bot added this to the v1.9.0 milestone May 17, 2022
@vpnachev vpnachev deleted the 3rd-party/update-k8schain branch May 18, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosigned] Cosigned does not use the provided imagePullSecret for GCR when running in GCP
4 participants