Remove knative/pkg deps #2092
Merged
Remove knative/pkg deps #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we were depending on knative/pkg for logging, now we just log.Printf - we were depending on knative/pkg for worker goroutine pooling, now just using errgroup and limiting to NumCPU ourselves Dropping knative deps should drop a bunch of transitive deps as well. Signed-off-by: Jason Hall <jason@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 26.33% 26.27% -0.07%
==========================================
Files 129 129
Lines 7564 7574 +10
==========================================
- Hits 1992 1990 -2
- Misses 5317 5329 +12
Partials 255 255
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
mattmoor
reviewed
Jul 22, 2022
mattmoor
reviewed
Jul 22, 2022
mattmoor
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.Printferrgroupand limiting workers to to NumCPU ourselvesDropping knative deps should drop a bunch of transitive deps as well.
Signed-off-by: Jason Hall jason@chainguard.dev
Summary
Reducing unnecessary dependencies limits our exposure to vulnerabilities in those dependencies.
This change has no effect on binary size (
cosignis still 83 MB 🏋️ )Release Note
NONE
Documentation
NONE
cc @mattmoor