Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove knative/pkg deps #2092

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Remove knative/pkg deps #2092

merged 3 commits into from
Jul 25, 2022

Commits on Jul 22, 2022

  1. Remove knative/pkg deps 

    - we were depending on knative/pkg for logging, now we just log.Printf
- we were depending on knative/pkg for worker goroutine pooling, now
  just using errgroup and limiting to NumCPU ourselves

Dropping knative deps should drop a bunch of transitive deps as well.

Signed-off-by: Jason Hall <jason@chainguard.dev>
    @imjasonh
    imjasonh committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    36c44a9 View commit details
    Browse the repository at this point in the history

  2. buffer channels 

    Signed-off-by: Jason Hall <jason@chainguard.dev>
    @imjasonh
    imjasonh committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    d8f6a28 View commit details
    Browse the repository at this point in the history

  3. Use errgroup.SetLimit instead of trying to be clever 

    Signed-off-by: Jason Hall <jason@chainguard.dev>
    @imjasonh
    imjasonh committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    86fece7 View commit details
    Browse the repository at this point in the history