Use pull_request_target for e2e tests. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
May 12, 2022
pull_request doesn't allow for usage of OIDC tokens, so the test sign+verify workflow can't run. Although this is generally discouraged by GitHub (see https://securitylab.github.com/research/github-actions-preventing-pwn-requests/), this is useful as an e2e testing tool for testing. Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pull_request doesn't allow for usage of OIDC tokens, so the test
sign+verify workflow can't run. Although this is generally discouraged
by GitHub (see
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/),
this is useful as an e2e testing tool for testing.
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
n/a
Release Note