-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move github.com/sigstore/protobuf-specs users into a separate subpackage #1511
Conversation
Nothing else in this repository currently uses sigstore/protobuf-specs, notably prodution users of pkg/client don't use it. So, move the new TLE utilities into a separate subpackage, to make clients smaller. Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
(Also the |
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
+ Coverage 66.96% 66.97% +0.01%
==========================================
Files 82 83 +1
Lines 8406 8406
==========================================
+ Hits 5629 5630 +1
Misses 2101 2101
+ Partials 676 675 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It is anticipated that users of pkg/client will make use of the TLE, as we work towards wider adoption of the sigstore bundle format defined in protobuf-specs; but I understand your concern on space and the dependency graph. If you're really space constrained, I would recommend just writing your own client against the REST API rather than importing pkg/client. |
Thanks, that’s good to know; I certainly don’t want to keep futilely pushing against. and disrupting, intentional and planned work. A separately-maintained client is quite practical for the current API, we’ll need to see how that works for the new data types. Actually protobuf might not make a difference for us, it’s more likely the dependency stack of @Luap99 FYI . |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Miloslav Trmač <mitr@redhat.com>
> go get github.com/sigstore/rekor@55a5a338d149407ceb0e047103cba1fdf1f2e38c > make vendor Shrinks the macOS binary by 1.87 MB. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
> go get github.com/sigstore/rekor@55a5a338d149407ceb0e047103cba1fdf1f2e38c > make vendor Shrinks the macOS binary by 1.87 MB. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Summary
Nothing else in this repository currently uses sigstore/protobuf-specs, notably prodution users of pkg/client don't use it. So, move the new TLE utilities into a separate subpackage, to make clients smaller.
I’m not sure what the long-term plan is, but at least short-term avoiding these dependencies in clients seems valuable. Compare #1469.
Release Note
NONE
Documentation
N/A