Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nnodes contain the language in several fields #1965

Open
Omikhleia opened this issue Jan 21, 2024 · 0 comments
Open

nnodes contain the language in several fields #1965

Omikhleia opened this issue Jan 21, 2024 · 0 comments
Labels
refactor Code quality improvements
Milestone
v0.x.y

Comments

@Omikhleia
Copy link
Member

The language is in node.language (tracked back to shaper:formNnode) and in node.options.language
It needs to be in the options (for createNnodes etc.). We however have two possibilities and we use one or the other at different places. That's code smell -> I would suggest a dedicated refactoring issue...

Originally posted by @Omikhleia in #1964 (comment)
@Omikhleia Omikhleia added the refactor Code quality improvements label Jan 21, 2024
@Omikhleia Omikhleia mentioned this issue Jan 21, 2024
Merged
@alerque alerque added this to the v0.x.y milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code quality improvements
Projects
Language settings overhaul
Status: Todo
Milestone
v0.x.y
Development

No branches or pull requests
2 participants
@alerque @Omikhleia