Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful_shutdown_timeout sometimes doesn't work on python 2 #7

Closed
sileht opened this issue Sep 27, 2016 · 1 comment
Closed

graceful_shutdown_timeout sometimes doesn't work on python 2 #7

sileht opened this issue Sep 27, 2016 · 1 comment

Comments

@sileht
Copy link
Owner

sileht commented Sep 27, 2016

When Service.terminate use time.sleep() signal.alarm doesn't work as expected on py27:

https://github.com/sileht/cotyledon/blob/master/cotyledon/__init__.py#L148-L150

https://github.com/sileht/cotyledon/blob/master/cotyledon/tests/test_cotyledon.py#L206-L208

Need to figure why and/or found a workaround.

@sileht
Copy link
Owner Author

sileht commented Sep 29, 2016

Because of the signals implementation the current cotyledon code doesn't work as expected. Some times signals are lost because of https://bugs.python.org/issue5315 I have used time.sleep to mitigate the issue but it looks like not enought, for example ceilometer-collector doesn't stop on SIGTERM even have the shutdown timeout the SIGALRM handler is not called.

@sileht sileht closed this as completed in 0cc2ca5 Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant