Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tedis does not surface errors #19

Closed
sshivananda opened this issue Oct 22, 2018 · 1 comment
Closed

tedis does not surface errors #19

sshivananda opened this issue Oct 22, 2018 · 1 comment

Comments

@sshivananda
Copy link

https://github.com/myour-cc/tedis/blob/1c34b70df30afb7146257715950599c3f8077a77/src/core/base.ts#L54 rejects with the response instead of the error.
Causing the message to show up as undefined and the actual error to be swallowed.

@dasoncheng
Copy link
Contributor

https://github.com/myour-cc/tedis/blob/1c34b70df30afb7146257715950599c3f8077a77/src/core/protocol.ts#L5

First of all, thank you very much for your feedback! the question is mainly caused by semantics. The returned information in the protocol module is placed in the res

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants