Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #635 (generated pdf contains only the address of an _io.BytesIO object) #636

Merged
merged 3 commits into from Feb 7, 2019

Conversation

jeromecc
Copy link
Contributor

@jeromecc jeromecc commented Feb 6, 2019

Many thanks to Bogdan Petrea from Presslabs for his help, hints & lines of code.

@bogdanpetrea
Copy link
Contributor

Thanks @jeromecc . The tests are passing but linting is failing apparently: https://travis-ci.org/silverapp/silver/jobs/489565179#L580
Also if you want to squash the commits, otherwise I can do it when I merge the branch.

@jeromecc
Copy link
Contributor Author

jeromecc commented Feb 6, 2019

Ok I see that you were not joking about code formatting. Linting is not joking about blank lines count either! :-)

Code style
The code should be properly formatted acording to PEP8, using 4 spaces.

I fixed my Eclipse setup to check for PEP8 shenanigans correctly. I will squash the commits. Hold tight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants