Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build & Automate docker image build #155

Closed
Clivern opened this issue Sep 26, 2019 · 10 comments
Closed

Build & Automate docker image build #155

Clivern opened this issue Sep 26, 2019 · 10 comments

Comments

@Clivern
Copy link
Member

Clivern commented Sep 26, 2019

No description provided.

@sourabhdeshmukh
Copy link

Will you please describe the details about this issue. It looks interesting for contribution.

@Clivern
Copy link
Member Author

Clivern commented Sep 27, 2019

It would be nice if you update the dockerfile to a multistage build.
On first stage

  • install requirements.
  • run the following to build assets and move them to static dir.
$ python manage.py collectstatic

On the second stage:

  • we need to copy the final code from builder stage.

I can take care of the automate part using travis

@sourabhdeshmukh
Copy link

Ok Thanks I will try my hand on this. Thank You :) for details.

@sourabhdeshmukh
Copy link

sourabhdeshmukh commented Sep 30, 2019

I have updated the Dockerfile according changes as you have mentioned in the description. I will send a PR tomorrow.
It will count in my Hactoberfest 2019. :)

@Clivern
Copy link
Member Author

Clivern commented Sep 30, 2019

Nice, Thanks @sourabhdeshmukh. I also automated the image build, you can see that on master branch https://hub.docker.com/r/clivern/silverback

@sourabhdeshmukh
Copy link

There is something wrong with https://hub.docker.com/r/clivern/silverback image.
When I executed following steps
Steps executed:
docker pull clivern/silverback
docker run -d -p 8000:8000 clivern/silverback:latest

Container spawn up successfully but when redirected to browser

Error Message: On browser http://0.0.0.0:8000 error
OperationalError at /
no such table: django_session

error.log

@Clivern
Copy link
Member Author

Clivern commented Sep 30, 2019

Yeah because it still not ready yet, after i merge your PR, will provide default configs to make stuff work

@sourabhdeshmukh
Copy link

sourabhdeshmukh commented Sep 30, 2019

Sent PR for review #163. Please check and confirm the request.
If any changes required please ask me I will modify it accordingly.

@Clivern
Copy link
Member Author

Clivern commented Oct 1, 2019

Thanks @sourabhdeshmukh

@Clivern Clivern closed this as completed Oct 1, 2019
@sourabhdeshmukh
Copy link

Thanks @Clivern for allowing me to contribute. :) I will check with other issues if I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment