New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RpcDecompiler/InternalComplexTypesMisc.cpp processCorrelationDescriptorNaked, expression is always false #26

Closed

hfiref0x opened this issue Jan 15, 2019 · 0 comments

Contributor

hfiref0x commented Jan 15, 2019

There is a logical error in conditional statement in processCorrelationDescriptorNaked function.

The condition is an if(condition1) else if(condition2) else if(condition3).

It starts with

RpcView/RpcDecompiler/InternalComplexTypesMisc.cpp

Line 511 in c108da2

if(confDesc.corrDesc.correlation_type & FC_TOP_LEVEL_CONFORMANCE)

next "else if"

RpcView/RpcDecompiler/InternalComplexTypesMisc.cpp

Line 523 in c108da2

    
           else if(confDesc.corrDesc.correlation_type & FC_POINTER_CONFORMANCE) // case of FC_POINTER_CONFORMANCE

next "else if"

RpcView/RpcDecompiler/InternalComplexTypesMisc.cpp

Line 549 in c108da2

    
           else if(confDesc.corrDesc.correlation_type & FC_POINTER_CONFORMANCE) // case of FC_TOP_LEVEL_MULTID_CONFORMANCE

The last one is always false and probably copy-paste misprint, judging from comment. Condition should be FC_TOP_LEVEL_MULTID_CONFORMANCE but not FC_POINTER_CONFORMANCE as it was checked before.

silverf0x closed this as completed in

b495f68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment