Compatibility with Sass 3.4 and SilverStripe 3.2/3.3 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'latest' as default, new option '3.4' for the latest 3.x version – maybe rename '3' to '3.2'? Users can change to alternative version in mystic/_config.php by e.g.: Compass::$sass_version = '3.4';
nicer web view of dev/compass/rebuild by adding some <br>s skip silverstripe cms and framework for faster compiling – usually you never change silverstripe core files, if you're working on own web project
how to choose required Sass version in projects _config.php
|
By analyzing the blame information on this pull request, we identified @helpfulrobot, @wilr and @hafriedlander to be potential reviewers |
| @@ -290,15 +301,15 @@ public function rebuild($verbose = false) | |||
| $this->rebuildDirectory($dir); | |||
| } else { | |||
| if ($verbose) { | |||
| echo "\nRebuilding all\n"; | |||
| echo "\nRebuilding all<br>\n"; | |||
There was a problem hiding this comment.
Add these HTML tags is probably a bad idea and scope creep of this PR.
There was a problem hiding this comment.
Ok, I also thought this is a bad idea. But if you rebuild in browser by dev/compass/rebuild you get all the messages in one line
I'll take it out and that "module skipping" below und make a new Pull.
|
Thanks for the feedback. If you just amend the current branch this PR will update automatically. and remove the commits you don't need, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this changes we can use Compass module on latest SilverStripe versions and Ubuntu 14.04 (with ruby-dev installed)