BUGFIX Database::doesSchemaNeedUpdating() if schemaUpdateTransaction …

…is NULL, then return FALSE. If schemaUpdateTransaction is an array, then return TRUE. This replaces the automatic casting which is not clear.
silverstripe-scienceninjas · May 10, 2012 · f30a3bd · f30a3bd
1 parent 7dcfdb0
commit f30a3bd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/model/Database.php b/model/Database.php
@@ -230,9 +230,9 @@ function cancelSchemaUpdate() {
 	 * Returns true if schema modifications were requested after a beginSchemaUpdate() call.
 	 */
 	function doesSchemaNeedUpdating() {
-		return (bool)$this->schemaUpdateTransaction;
+		return ($this->schemaUpdateTransaction === null) ? false : true;
 	}
-	
+
 	// Transactional schema altering functions - they don't do anyhting except for update schemaUpdateTransaction
 
 	/**