Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Front end improvements #1595

Open
25 tasks
sabina-talipova opened this issue Oct 16, 2023 · 0 comments
Open
25 tasks

Miscellaneous Front end improvements #1595

sabina-talipova opened this issue Oct 16, 2023 · 0 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 16, 2023

Description

We are planning to update the User Interface and most likely we can refactor some classes and make the following improvements.

CSS

  • Refactor the CSS files to implement the BEM approach for class naming.
  • Reduce CSS class nesting.
  • Update / Remove CSS styles once we remove jqueryui.
  • Remove ID style wherever it is possible
  • Create pagination component. See
  • Badge.scss - replace .status-archived class name with .badge--[modifier]. See
  • Breadcrumb.scss - .breadcrumb__item-** fix Bootstrap clash. See and here
  • Form.scss:
    • rename .file ccs class name to a different class name as it conflicts with default bootstrap. See
    • fix for when the .form-group--no-label class is used but there is actually a label. See
    • reduce css class nesting. See
    • make label display on the right side like normal .form__field-extra-label. See
  • FormAction.scss:
    • Separate out bootstrap btn reset styles to a separate style sheet or divide within this sheet. See
    • Rename component to something like Btn or Button? See
    • .btn--icon-large to be deprecated across CMS. Check that we don't use this class name.
    • replace all .no-text classes for .btn--no-text
    • all secondary buttons need to change to use .btn-light. See
    • .btn-hide-outline - change word "outline" to border. See
  • _layout.scss - .CMSPageEditController, .CMSPageSettingsController - move out of layout. See

JS

  • FormAlert.js - default this.props.visible as null. See
  • FormBuilder.js - Add generic CMS error reporting.See
  • DateField.js / DatetimeField.js - add validation in onchange() function
  • LeftAndMain.FieldHelp.js - remove attribute title setting, shouldn't be necessary
  • Backend.js - Add support for nested keys to applySchemaToData()
@GuySartorelli GuySartorelli changed the title TODO: Miscellaneous Front end improvements Miscellaneous Front end improvements Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant