Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: GridField Component Improvements #1596

Closed
3 tasks
sabina-talipova opened this issue Oct 16, 2023 · 3 comments
Closed
3 tasks

TODO: GridField Component Improvements #1596

sabina-talipova opened this issue Oct 16, 2023 · 3 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 16, 2023

Description

See:

* @todo Convert to higher order component which hooks up form
* schema data to an API backend as a grid data source
* @todo Replace "dumb" inner components with third party library (e.g. https://griddlegriddle.github.io)

  • Convert to higher order component which hooks up form schema data to an API backend as a grid data source
  • Replace "dumb" inner components with third party library (e.g. https://griddlegriddle.github.io)
  • Replace <div>{ i18n._t('CampaignAdmin.LOADING', 'Loading...') }</div> with better loading indicator. See
@GuySartorelli
Copy link
Member

@sabina-talipova it's not clear what is meant by "dumb" inner components, and that griddle link is a 404 - can you please either clarify what the intention was or remove that point?

If that point ends up being removed then I think we can close this issue, as the other points aren't worth doing on their own IMO.

@sabina-talipova
Copy link
Contributor Author

I assume that the idea was to replace createRow and createCells and so on, with this JS module - Griddle

@GuySartorelli
Copy link
Member

I'm going to close this for now - we're not likely to spend time working on small parts of the js of gridfield.
I suspect next time we look at enhancing or improving the gridfield javascript, it will be more akin to a complete overhaul or replacement.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants