Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: GridFieldTable Component refactoring #1597

Closed
sabina-talipova opened this issue Oct 16, 2023 · 1 comment
Closed

TODO: GridFieldTable Component refactoring #1597

sabina-talipova opened this issue Oct 16, 2023 · 1 comment
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 16, 2023 •
edited
Loading

Description

You should analyze the GridFieldTable Component and determine whether this component requires props.data. If not, then we should remove this value from the component.
See:
This was referenced Oct 16, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

Closing as I don't think we need the additional generation logic but it's also not worth our time right now to remove the unused prop.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova