Error message from server contains extraneous markup

[gmlnchv]

Overview

Error messages that come straight from the server are not readable to the CMS user.

One example is PDF files exceeding the specified maximum file size (for the server) seem to have some extraneous markup surrounding the error message.

Recreation steps

1. Use a project hosted on Silverstripe Cloud (e.g. demo.silverstripe.org)
2. Upload a 13mb image to asset-admin
3. Observe error

Acceptance criteria

• Where the error message/ response comes straight from the server, exclude any HTML tags, ensuring the messaging is readable
• Look at the common status codes and create a specific error message, or default to a generic error message
• If any new translation strings are introduced, ensure they're pushed to Transifex

Notes

• Similar work has recently been done in the silverstripe/mfa module

[robbieaverill]

Oh, that's probably coming from your web server (apache/nginx)! Is this reproducible on a vanilla installation by posting an enormous file at it? Could you please share some information about the versions you're running as well as any custom config, web server config etc? If you're running nginx especially

[gmlnchv]

@robbieaverill you are right - I could only reproduce this on SilverStripe Platform. Fresh SS4 installation doesn't seem to have this :) Should probably close and raise with the Platform instead?

[robbieaverill]

@gmlnchv I think you can leave the issue open, but maybe raise a helpdesk issue and reference this GitHub issue in it

[chillu]

The frontend logic should be looking at the status code as well as the content type of the response. If it's text/html, then don't use it. If it's application/json, then try to parse it for error messages. If it's text/plain, display it. In all cases, the output should be sanitised.

[gmlnchv]

@gmlnchv I think you can leave the issue open, but maybe raise a helpdesk issue and reference this GitHub issue in it

@robbieaverill Still worthwhile raising with the helpdesk or can be fixed here you think?

[robbieaverill]

@gmlnchv I would suggest raising a ticket and reference this issue

[robbieaverill]

This is still an issue. I replicated earlier today by uploading a 13mb image to asset-admin on demo.silverstripe.org.

[emteknetnz]

Fixed in #1138

[emteknetnz]

Re-opening, linked PR hasn't been merged yet