MNT Remove TODO comments #1413
Merged
MNT Remove TODO comments #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
ac0fb78
to
2b0eb83
Compare
sabina-talipova
commented
Oct 19, 2023
| @@ -283,8 +283,6 @@ class AssetAdmin extends Component { | |||
| this.handleOpenFile(response.record.id); | |||
| } | |||
|
|
|||
| // TODO Update GraphQL store with new model, | |||
| // see https://github.com/silverstripe/silverstripe-graphql/issues/14 | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -477,9 +475,6 @@ class AssetAdmin extends Component { | |||
| */ | |||
| handleUnpublish(fileIds) { | |||
| return this.doUnpublish(fileIds).then((response) => { | |||
| // TODO Update GraphQL store with new model or update apollo and use new API | |||
| // see https://github.com/silverstripe/silverstripe-graphql/issues/14 | |||
| // see https://dev-blog.apollodata.com/apollo-clients-new-imperative-store-api-6cb69318a1e3 | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -558,7 +552,6 @@ class AssetAdmin extends Component { | |||
| } | |||
|
|
|||
| handleMoveFilesSuccess(folderId, fileIds) { | |||
| // TODO Refactor "queued files" into separate visual area and remove coupling here | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -799,7 +790,6 @@ function mapStateToProps(state, ownProps) { | |||
| const { formSchema } = state.assetAdmin.modal; | |||
| return { | |||
| securityId: state.config.SecurityID, | |||
| // TODO Refactor "queued files" into separate visual area and remove coupling here | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -812,7 +802,6 @@ function mapDispatchToProps(dispatch) { | |||
| gallery: bindActionCreators(galleryActions, dispatch), | |||
| toasts: bindActionCreators(toastsActions, dispatch), | |||
| displaySearch: bindActionCreators(displaySearchActions, dispatch), | |||
| // TODO Refactor "queued files" into separate visual area and remove coupling here | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -25,7 +25,6 @@ class HistoryItem extends Component { | |||
| } | |||
|
|
|||
| return ( | |||
| // @todo wrap the contents in an `<a>` tag | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| @@ -47,7 +45,7 @@ class HistoryList extends Component { | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps) { | |||
| // TODO race conditions happening, this should have history state shifted to redux | |||
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
|
|
||
| // Sometimes AssetAdmin.js handleSubmitEditor() can't find the file | ||
| // @todo Ensure that we always return a file for any valid ID | ||
|
|
There was a problem hiding this comment.
sabina-talipova
commented
Oct 19, 2023
| // todo: | ||
| // Refactor this once Apollo GraphQL adds support | ||
| // for invalidating specific queries in the cache. | ||
| // Context: https://github.com/silverstripe/silverstripe-asset-admin/issues/809 |
There was a problem hiding this comment.
GuySartorelli
requested changes
Oct 25, 2023
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
2b0eb83
to
7839987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue