Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use caching instead of polling in HistoryList #1412

Open
sabina-talipova opened this issue Oct 17, 2023 · 0 comments
Open

Use caching instead of polling in HistoryList #1412

sabina-talipova opened this issue Oct 17, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

Description

To determine if the history list requires a refresh we send request every 250 ms in refreshHistoryIfNeeded.

This needs a delay/throttle, so this api request tries to be made last in the stack. We also use this to stop an API call happening if the component is going to unmount soon.

This could potentially be solved by using apollo-client's caching and graphql.
See:

silverstripe-asset-admin/client/src/containers/HistoryList/HistoryList.js

Line 78 in 02728e1

* TODO: This could potentially be solved by using apollo-client's caching and graphql.

This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: Investigate the potential improvements for HistoryList Use caching instead of polling in HistoryList Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @sabina-talipova