Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CMSMain and its subclasses #2896

Closed
sabina-talipova opened this issue Oct 11, 2023 · 1 comment
Closed

Refactor CMSMain and its subclasses #2896

sabina-talipova opened this issue Oct 11, 2023 · 1 comment

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 11, 2023

Description

See:

* @todo Create some base classes to contain the generic functionality that will be replicated.

This "TODO" comment was created in 2016. We need to investigate this matter and assess its current relevance.

CMSMain and its subclasses are a mess. We should look at refactoring these, preferably in a generic way that provides a more generic "TreeModelAdmin" style class. The CMSMain could just be a subclass of that.
We should ideally not need a sub CMSPageAddController, CMSPageEditController, CMSPageSettingsController, CMSPagesontroller, etc.

@GuySartorelli GuySartorelli changed the title TODO: CMSMain - Investigate possibility to create some base classes to contain the generic functionality that will be replicated Refactor CMSMain and its subclasses Oct 19, 2023
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6 milestone Oct 20, 2023
@GuySartorelli
Copy link
Member

Closing as a dupe of silverstripe/.github#257

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants