FIX (partial) for #1288 where non-submit buttons are being activated on "enter" key press. #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g activated on "enter" key press (relates to framework issue at silverstripe/silverstripe-framework#3181).
This was referenced Oct 5, 2015
|
This is a good fix, but we would prefer to merge this into the 3 rather than 3.1 branch. 3.1 branch should not be receiving anything other than fixes to critical issues. Any non-critical (e.g. quality of life improvements) should be either 3.2 or 3 branches. Similarly to 3.1, 3.2 is nearing stable release, and we don't want to introduce any bugfixes there that aren't strictly necessary. Could you please re-open this there for cms and framework pull requests? |
|
No problem. |
|
Ok -- new PR here: #1292 Trying to keep organized in this tangled mess of PR's :) Links and etc are updated. |
stephenmcm
pushed a commit
to stephenmcm/silverstripe-quickaddnew
that referenced
this pull request
May 25, 2016
sheadawson
added a commit
to sheadawson/silverstripe-quickaddnew
that referenced
this pull request
Oct 14, 2016
* master: fix(quickaddnew.css): Fix CSS so that the addnew button appears beside the chosen field in a way that works responsively. Fix enter key presses in input dialogs triggering the add new button. see: silverstripe/silverstripe-cms#1290 added croatian translation Added standard Scrutinizer config Adjusting codestyle a bit and adding phpdoc blocks Fixing phpdoc blocks to refering to Objects to built-in types of PHP Remove trailing spaces in the source code Fixing composer.json Converted to PSR-2 Added standard .editorconfig file Create LICENSE.md add support for Translatable or other instances when form action contains url parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue (and fix for #1288) relates to framework issue at silverstripe/silverstripe-framework#3181 and associated pull request: silverstripe/silverstripe-framework#4651
PLEASE NOTE: This is a combined fix across both repositories. The actual bug reported in #1288 is addressed in the other pull request (linked above and here).