FIX (partial) for #3181 where non-submit buttons are being activated on "enter" key press.

[patricknelson]

This issue (and fix for #3181) relates to CMS issue at silverstripe/silverstripe-cms#1288 and associated pull request: silverstripe/silverstripe-cms#1290

PLEASE NOTE: This is a combined fix across both repositories and ensures that all non-submit buttons are defined explicitly as type button to ensure browsers will not automatically register the first occurrence after someone presses the enter key.

• CMS:
  • Issue: JavaScript is clicking first button in form when pressing "enter" key. silverstripe-cms#1288
  • PR: FIX (partial) for #1288 where non-submit buttons are being activated on "enter" key press. silverstripe-cms#1290
• Framework:
  • Issue: BUG UploadField hijacking return key #3181
  • PR: FIX (partial) for #3181 where non-submit buttons are being activated on "enter" key press. #4651 (you are here)

[tractorcow]

This is a good fix, but we would prefer to merge this into the 3 rather than 3.1 branch. 3.1 branch should not be receiving anything other than fixes to critical issues. Any non-critical (e.g. quality of life improvements) should be either 3.2 or 3 branches. Similarly to 3.1, 3.2 is nearing stable release, and we don't want to introduce any bugfixes there that aren't strictly necessary.

Could you please re-open this there for cms and framework pull requests?

[patricknelson]

Sure.

[patricknelson]

Ok -- new PR here: #4662

Trying to keep organized in this tangled mess of PR's :) Links and etc are updated.