MINOR Fixed UploadField edit forms falsely expanding by default

silverstripe · Mar 1, 2012 · 0b0e24b · 0b0e24b
1 parent f8201c4
commit 0b0e24b
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/javascript/UploadField.js b/javascript/UploadField.js
@@ -196,18 +196,26 @@
 			}
 		});
 		$('div.ss-upload .ss-uploadfield-item-editform').entwine({
+			fitHeight: function() {
+				var iframe = this.find('iframe'), h = iframe.contents().height();
+				// Set iframe to match its contents height
+				iframe.height(h); 
+				// set container to match the same height
+				iframe.parent().height(h);
+			},
 			toggleEditForm: function() {
-				jQuery(this).toggle();
+				if(this.height() === 0) {
+					this.fitHeight();	
+				} else {
+					this.height(0);
+				}
 			}
 		});
 		$('div.ss-upload .ss-uploadfield-item-editform iframe').entwine({
 			onmatch: function() {
+				// TODO entwine event binding doesn't work for iframes
 				this.load(function() {
-					var iframe = $(this), h = iframe.contents().height();
+					$(this).parent().removeClass('loading');	
-					// Set iframe to match its contents height
-					iframe.height(h); 
-					// set container to match the same height
-					iframe.parent().removeClass('loading').height(h);
 				});
 			}
 		});